feat: coordinate transformation functions with momentum names#424
Merged
Saransh-cpp merged 3 commits intoFeb 21, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
+ Coverage 82.70% 82.87% +0.17%
==========================================
Files 96 96
Lines 11453 11533 +80
==========================================
+ Hits 9472 9558 +86
+ Misses 1981 1975 -6 ☔ View full report in Codecov by Sentry. |
a81ba39 to
69c4872
Compare
58f9c40 to
11a13fc
Compare
jpivarski
approved these changes
Feb 20, 2024
Member
jpivarski
left a comment
There was a problem hiding this comment.
Looks good to me! The problem with momentum names is that the temporal coordinate names are very overloaded: E, e, energy and M, m, mass. (I don't think we should have all combinations; there are a lot of combinations!)
If someone's using this in an environment that has tab-complete, that should help a lot. That's why it's good that the alias you chose is the fully spelled-out word: the lower-case single-letter will expand to that, at least.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #168
Checklist
$ pre-commit run --all-filesor$ nox -s lint)$ pytestor$ nox -s tests)$ cd docs; make clean; make htmlor$ nox -s docs)$ pytest --doctest-plus src/vector/or$ nox -s doctests)Before Merging