MAINT handle deprecations from `importlib.resources` by jjerphan · Pull Request #25157 · scikit-learn/scikit-learn

jjerphan · 2022-12-09T15:55:30Z

Reference Issues/PRs

Fix a problem first observed in skops-dev/skops#246

What does this implement/fix? Explain your changes.

Some utils from importlib.resources has been deprecated in Python 3.11:

See: https://docs.python.org/3/library/importlib.resources.html#importlib.resources.open_text

Any other comments?

`importlib.resources.open_text` has been deprecated in Python 3.11. See: https://docs.python.org/3/library/importlib.resources.html#importlib.resources.open_text

adrinjalali · 2022-12-09T17:21:22Z

I think the API was introduced in py3.9, so we need an entry in fixes.py for this 🙈

jeremiedbb · 2022-12-09T17:53:38Z

We should put that in 1.2.1 to spare some warnings to the users

glemaitre · 2022-12-12T09:06:02Z

It seems that this is not compatible with Python 3.8:

AttributeError: module 'importlib.resources' has no attribute 'files'

Ups, did not see the previous comment. Using fixes seems good

glemaitre · 2022-12-12T09:07:20Z

We should probably have an if ... else ... depending on the python version since your changes are the recommended ones.

glemaitre · 2022-12-12T10:07:45Z

Note that we will have the same issue with open_binary, read_text, etc. I am going to try to solve these issues together with the other deprecation breakage in scipy since they are blocking the CI.

glemaitre · 2022-12-12T10:29:20Z

I made a push with the handling of those specific importlib.resources since we might want only to cherry-pick those changes (and not other SciPy (not sure yet)).

jjerphan · 2022-12-12T10:44:42Z

+def _open_text(data_module, data_file_name):
+    if sys.version_info >= (3, 9):
+        return resources.files(data_module).joinpath(data_file_name).open("r")
+    else:
+        return resources.open_text(data_module, data_file_name)
+
+
+def _open_binary(data_module, data_file_name):
+    if sys.version_info >= (3, 9):
+        return resources.files(data_module).joinpath(data_file_name).open("rb")
+    else:
+        return resources.open_binary(data_module, data_file_name)
+
+
+def _read_text(descr_module, descr_file_name):
+    if sys.version_info >= (3, 9):
+        return resources.files(descr_module).joinpath(descr_file_name).read_text()
+    else:
+        return resources.read_text(descr_module, descr_file_name)
+
+
+def _path(data_module, data_file_name):
+    if sys.version_info >= (3, 9):
+        return resources.as_file(resources.files(data_module).joinpath(data_file_name))
+    else:
+        return resources.path(data_module, data_file_name)


Would it make sense to commute functions' definitions with the test based for sys.version_info >= (3, 9)? This would be:

if sys.version_info >= (3, 9): # Use the newest preferred interfaces chaining of `importlib`. _open_text = # ... _open_binary = # ... _read_text = # ... _path = # ... else: _open_text = resources.read_text _open_binary = resources.open_binary _read_text = resources.read_text _path = resources.path

But that's probably harder to define.

Since the arguments are not dispatched in the same way, I don't think that we will end-up with more readable knowing that we are going to drop it soonish.

glemaitre · 2022-12-12T11:39:13Z

It remains is_resource. I will make the change after launch.

glemaitre

LGTM

ogrisel

LGTM as well. Thanks for the fix!

jjerphan · 2022-12-13T11:00:42Z

Thank you for finishing this, @glemaitre.

) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

jjerphan added the No Changelog Needed label Dec 9, 2022

github-actions Bot added the module:datasets label Dec 9, 2022

jjerphan mentioned this pull request Dec 9, 2022

MNT add python=3.11 support skops-dev/skops#246

Merged

Fix replace deprecated importlib.resources.open_text

e655221

`importlib.resources.open_text` has been deprecated in Python 3.11. See: https://docs.python.org/3/library/importlib.resources.html#importlib.resources.open_text

jjerphan force-pushed the fix/replace-importlib.resources.open_text branch from a510b9a to e655221 Compare December 9, 2022 16:01

jeremiedbb added this to the 1.2.1 milestone Dec 9, 2022

glemaitre self-assigned this Dec 12, 2022

MAINT handle deprecation in importlib.resources

7f70149

glemaitre changed the title ~~FIX Replace deprecated importlib.resources.open_text~~ MAINT handle deprecations from importlib.resources Dec 12, 2022

glemaitre removed their assignment Dec 12, 2022

jjerphan commented Dec 12, 2022

View reviewed changes

adrinjalali approved these changes Dec 12, 2022

View reviewed changes

glemaitre self-requested a review December 12, 2022 13:17

add is_resource

e1ac7ea

glemaitre approved these changes Dec 13, 2022

View reviewed changes

glemaitre added Quick Review For PRs that are quick to review Waiting for Second Reviewer First reviewer is done, need a second one! labels Dec 13, 2022

glemaitre mentioned this pull request Dec 13, 2022

MAINT fix deprecation raised in scipy-dev build #25175

Merged

ogrisel approved these changes Dec 13, 2022

View reviewed changes

ogrisel merged commit f2c78fe into scikit-learn:main Dec 13, 2022

ogrisel added To backport PR merged in master that need a backport to a release branch defined based on the milestone. and removed Waiting for Second Reviewer First reviewer is done, need a second one! labels Dec 13, 2022

jjerphan deleted the fix/replace-importlib.resources.open_text branch December 13, 2022 11:00

Vincent-Maladiere pushed a commit to Vincent-Maladiere/scikit-learn that referenced this pull request Dec 14, 2022

MAINT handle deprecations from importlib.resources (scikit-learn#25157

b348be1

) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

jjerphan mentioned this pull request Dec 16, 2022

⚠️ CI failed on Linux_Nightly.pylatest_pip_scipy_dev ⚠️ #25164

Closed

jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 3, 2023

MAINT handle deprecations from importlib.resources (scikit-learn#25157

bc65200

) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023

MAINT handle deprecations from importlib.resources (scikit-learn#25157

fede701

) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023

MAINT handle deprecations from importlib.resources (scikit-learn#25157

55dccd3

) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

jjerphan added a commit to jjerphan/scikit-learn that referenced this pull request Jan 23, 2023

MAINT handle deprecations from importlib.resources (scikit-learn#25157

bcda708

) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

adrinjalali pushed a commit that referenced this pull request Jan 24, 2023

MAINT handle deprecations from importlib.resources (#25157)

71d1146

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

MAINT handle deprecations from `importlib.resources`#25157

MAINT handle deprecations from `importlib.resources`#25157
ogrisel merged 3 commits intoscikit-learn:mainfrom
jjerphan:fix/replace-importlib.resources.open_text

jjerphan commented Dec 9, 2022 •

edited by glemaitre

Loading

Uh oh!

adrinjalali commented Dec 9, 2022

Uh oh!

jeremiedbb commented Dec 9, 2022

Uh oh!

glemaitre commented Dec 12, 2022 •

edited

Loading

Uh oh!

glemaitre commented Dec 12, 2022

Uh oh!

glemaitre commented Dec 12, 2022

Uh oh!

glemaitre commented Dec 12, 2022

Uh oh!

jjerphan Dec 12, 2022

Uh oh!

glemaitre Dec 12, 2022

Uh oh!

glemaitre commented Dec 12, 2022

Uh oh!

glemaitre left a comment

Uh oh!

ogrisel left a comment

Uh oh!

jjerphan commented Dec 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

jjerphan commented Dec 9, 2022 • edited by glemaitre Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

Uh oh!

adrinjalali commented Dec 9, 2022

Uh oh!

jeremiedbb commented Dec 9, 2022

Uh oh!

glemaitre commented Dec 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

glemaitre commented Dec 12, 2022

Uh oh!

glemaitre commented Dec 12, 2022

Uh oh!

glemaitre commented Dec 12, 2022

Uh oh!

jjerphan Dec 12, 2022

Choose a reason for hiding this comment

Uh oh!

glemaitre Dec 12, 2022

Choose a reason for hiding this comment

Uh oh!

glemaitre commented Dec 12, 2022

Uh oh!

glemaitre left a comment

Choose a reason for hiding this comment

Uh oh!

ogrisel left a comment

Choose a reason for hiding this comment

Uh oh!

jjerphan commented Dec 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jjerphan commented Dec 9, 2022 •

edited by glemaitre

Loading

glemaitre commented Dec 12, 2022 •

edited

Loading