Skip to content

Conversation

@bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Jun 26, 2025

What problem does this PR address?

Closes #164

run: commands works:

jobs:
  tests-on-pr:
    uses: bobleesj/release-scripts/.github/workflows/_tests-on-pr.yml@run-command
    with:
      project: bobleesj.release
      c_extension: false
      headless: false
      run: |
        pip install gooey
        echo "Done"
Screenshot 2025-06-26 at 4 39 47 PM

Ref CI: https://github.com/bobleesj-test-org/bobleesj.release/actions/runs/15895768623/job/44826878474?pr=31

What should the reviewer(s) do?

Please review and merge.

  • This PR introduces a public-facing change (e.g., figures, CLI input/output, API).
    • Documentation (e.g., tutorials, examples, README) has been updated.
    • A tracking issue or plan to update documentation exists.
  • This PR affects internal functionality only (no user-facing change).

@bobleesj bobleesj changed the title Add run: option under test-on-pr.yml to allow running custom CLI commands like extra pip install. Add run: option under test-on-pr.yml to allow running custom CLI commands like extra pip install. Jun 26, 2025
@bobleesj
Copy link
Contributor Author

@sbillinge This is ready to be merged. Once merged, we can then merge from main to v0.

@sbillinge
Copy link
Contributor

@bobleesj sweet! can you let Zhi Ming know and he can test it for the gooey load....

@sbillinge sbillinge merged commit bdb88f5 into scikit-package:main Jun 26, 2025
2 checks passed
@bobleesj bobleesj deleted the run-command branch June 26, 2025 22:55
@bobleesj
Copy link
Contributor Author

yup sent a slack msg to zhiming to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: allow optionally installing dependencies via pip (like gooey) in test-on-pr.yml

3 participants