Skip to content

Conversation

@Tieqiong
Copy link
Contributor

@Tieqiong Tieqiong commented Sep 11, 2024

still need to add matrix test, waiting for diffpy/diffpy.pdfgui#205

Then do a test on pdfgui and pdffit2 after merge

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a meaningful way of reviewing this so I suggest I just merge it and we can test. Does that make sense @Tieqiong ?

@Tieqiong
Copy link
Contributor Author

Yes please. Thanks

@sbillinge sbillinge merged commit 8a87065 into scikit-package:main Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants