ci: use pyproject.toml Python version for build wheel, deploy docs, release #203
Conversation
bobleesj
changed the title
bobleesj
left a comment
bobleesj
left a comment
There was a problem hiding this comment.
@sbillinge ready for review. just like test-on-pr, user can also mnually specifiy the python version in the .yml file
| default: 'PROJECT_NAME' | ||
| required: true | ||
| type: string | ||
| python_version: |
There was a problem hiding this comment.
this .yml is for non-pure Python - use the pyython-version from the main _build-wheel-..yml file.
There was a problem hiding this comment.
@bobleesj do we need a comment in the code with this information so we don't forget in the future? Not sure, just asking.
| maintainer_github_username: ${{ inputs.maintainer_github_username }} | ||
|
|
||
| build-wheel: | ||
| get-python-version: |
There was a problem hiding this comment.
this .yml is for the main entry point for when git push upstream <tag> is called.
like in test-on-pr, we grab the latest Python version.
| default: false | ||
| required: true | ||
| type: boolean | ||
| python_version: |
There was a problem hiding this comment.
for builidng wheel, use the Python version passed from the top level
| description: 'Python version for Conda environment' | ||
| default: 3.14 | ||
| required: false | ||
| description: 'Python version to use for building documentation' |
There was a problem hiding this comment.
for building docs, again, same logic.
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.14' | ||
| python-version: ${{ inputs.python_version }} |
There was a problem hiding this comment.
for uploading to PyPI, again same logic. use the Python version passed from the main build-wheel-upload .yml file
|
@sbillinge ready for review |
Merge pull request #203 from bobleesj/build-get-pt-version v0
2 participants
Fixes scikit-package/scikit-package#632
Just like on test-on-pr, this PR grabs the latest Python version from .pyproject.toml