Use conda.txt instead of run.txt #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobleesj
commented
Oct 2, 2024
| - name: Install ${{ inputs.project }} and requirements | ||
| run: | | ||
| conda install --file requirements/run.txt | ||
| conda install --file requirements/run-ext.txt |
Contributor
Author
There was a problem hiding this comment.
as you've mentioned, I think adding run-ext adds an unwanted complexity.
What if we both include optional and required dependencies all under conda.txt instead?
We should test our software with all the dependencies installed anyway.. right?
Contributor
Author
There was a problem hiding this comment.
Furthermore, if we decide to use have a separate .txt file for ext pacakges, then we also need pip-ext.txt I don't think we want this..
bobleesj
commented
Oct 2, 2024
Contributor
|
yes, much better. I like it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.