Skip to content

Conversation

@bobleesj
Copy link
Collaborator

Addresses scikit-package/scikit-package#328

Screenshot 2025-04-23 at 6 06 37 PM

Testing is done:

Screenshot 2025-04-23 at 6 05 30 PM

@bobleesj bobleesj changed the title chore: rename file and folder names group's naming conventionst chore: rename file and folder names based on group's naming convention Apr 23, 2025
@sbillinge
Copy link
Contributor

Addresses Billingegroup/scikit-package#328
Screenshot 2025-04-23 at 6 06 37 PM

Testing is done:
Screenshot 2025-04-23 at 6 05 30 PM

I think the name of the test should be test_shared_functions.py?

@bobleesj
Copy link
Collaborator Author

bobleesj commented Apr 23, 2025

@sbillinge Ready for review - updated to test_shared_functions.py and also modified our latex file.

Screenshot 2025-04-23 at 6 15 48 PM

@sbillinge sbillinge merged commit 3b8339c into scikit-package:main Apr 23, 2025
@bobleesj bobleesj deleted the proper-file-folder-convention branch April 23, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants