addConsLocal updated and SCIPdelConsNode added#485
Closed
Conversation
* Prototype for addition of addExprConsNode to add ExprCons to Nodes. * Extract _createLinCons * Unify createCons and make addConsNode more compact. * Fix segfault caused by addConsNode when called with ExprCons
…e function, changelog updated
added 4 commits
March 18, 2021 09:42
…S* cons), added SCIPdelConsNode(SCIP* scip, SCIP_CONS* cons) to scip.pxd
Collaborator
Author
|
i restored the branch, but the issue here is that in the new SCIP version, the way nonlinear constraints are handled has changed dramatically, which is why that distinction is no longer valid as is i believe - but maybe we can make it work for the new version and merge it. |
Member
|
This has currently a lot of conflicts with the master branch, I will close it for now until it's ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on pull request in #418
Changelog updated.
Should the parameter "stickingatnode" in the addConsLocal function be True or False?
There are now two separate createCons functons, old:
and the new one added in #418 :
Is there a reason to have this distinction?