Skip to content

Patch 2#48

Merged
scline merged 2 commits intoscline:masterfrom
joey741019:patch-2
Aug 4, 2019
Merged

Patch 2#48
scline merged 2 commits intoscline:masterfrom
joey741019:patch-2

Conversation

@joey741019
Copy link
Copy Markdown
Contributor

Hotfix of PHP variables add space for sed correct replace and add change log

fix the space of equaltions
@jflemer-ndp
Copy link
Copy Markdown

It would be more robust to handle arbitrary space, including none with "<space>*". For example:

s/^\(memory_limit *=\).*/\1 ${PHP_MEMORY_LIMIT}/

@scline
Copy link
Copy Markdown
Owner

scline commented Aug 4, 2019

Thank you for contributing back @joey741019, apologize for the delay. Great advice @jflemer-ndp, if no one PR's that addition I will throw it in (^_^)

@scline scline merged commit 4410593 into scline:master Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants