Conversation
|
@scline I added retry logic that will prevent the process manager from killing the entire container, now it just waits until it can reach the llama server. Should be able to see where I killed my local connection to test. |
|
One thing I recently added. When the interval is changed on the server/config we We expose this value via API as well Right now I simply grep the config in the entrypoint of the probe to locate the interval: |
|
Ahh a hard value to check for! That makes comparing the config much easier! Let me see if I can cook something up with that, can also kill and restart the collector and not send HUP signal. |
|
@scline So if the interval changes we can kill the collector and reload the config ? |
|
I think the Likely easier logic that way, what are your thoughts on that? |
|
Can always add both and force -9 based on another config value. When would you even need to do -9? |
|
Only during an “interval” config change
…On Wed, Nov 24, 2021 at 2:42 PM Stephen Ellis ***@***.***> wrote:
Can always add both and force -9 based on another config value. When would
you even need to do -9?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBEKV7YUFYYLPSYHWSDPQDUNVS35ANCNFSM5G6SCROA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Lamoid Grazer
Go Application that manages the Reflector/Collector Processes and the checking of the collectors current running config and reloads the application if it detects a change in the config by way of MD5 compare.
I tried to keep the external packages to a minimum but for the most part this is a fairly lightweight process/configuration manager for the services.
House Keeping
.gitignoreto not upload local build artifactsREADME.MDbuild.shscript to try a push after building so removed that.Testing
Testing was done by compiling the binary and rebuilding the probe container. The main loop was modified to mimic the need to reload the config just so we can observe the process manager behavior and reload speed.
Main goal was to send SIGHUP to the collector forcing the reload.
Startup
Config Reload
and will reload. I have no idea if the collector actually reads the new config or just reuses a cached copy.
Config Compare
Hard to test this without spining up my own API server locally but for the most part its just writing both configs to the local nodes and doing an MD5 sum on the files to check if they match. Based on that a bool is returned to the main grazing loop.
TODOs:
This is in a usable state but I wanted to point out some improvements that will be submitted in the near future.
🥂
🦀