Skip to content

Conversation

@atait
Copy link
Collaborator

@atait atait commented Oct 13, 2020

Follows #12

Option to collapse iterables

I don't understand why they were collapsed in v0.1.0 but not v0.2.0. Am I missing something? I figured giving the user the option is best.

Option for explicit collapse

Fine tuning for when

  • you have potential global name conflicts
  • you want to unroll-then-collapse one part, and collapse-then-unroll another part of the function
  • pypragma does not support something in some other part of the function

@coveralls
Copy link

coveralls commented Oct 13, 2020

Pull Request Test Coverage Report for Build 109

  • 17 of 17 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 86.06%

Totals Coverage Status
Change from base Build 107: 0.1%
Covered Lines: 1068
Relevant Lines: 1241

💛 - Coveralls

@atait atait mentioned this pull request Oct 14, 2020
@atait atait merged commit 19087c0 into scnerd:develop Oct 17, 2020
@atait atait deleted the feature/collapse-opts branch October 17, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants