Conversation
Jonas-Kirchhoff
requested changes
Sep 16, 2025
Collaborator
Author
|
Title and subtitles added: |
|
If possible, could you add into the description that the list of bugs and misbehaviours is compiled from the github issues from nlohmann/json and that they link to there? |
Collaborator
Author
|
updated description: |
| # Add title to the output file | ||
| echo "# Misbehaviours Report" > $OUTPUT_FILE | ||
| echo "" >> $OUTPUT_FILE | ||
| echo "This report lists known misbehaviours or bugs of v3.12.0 of the nlohmann/json repository. The misbehaviours are compiled from github issues of the nlohmann/json repository, and links to each corresponding issue." >> $OUTPUT_FILE |
There was a problem hiding this comment.
Grammar: Is it "link to" or "links to"; or: Is "link" a verb or a substantive?
Jonas-Kirchhoff
left a comment
Jonas-Kirchhoff
left a comment
There was a problem hiding this comment.
Please check whether the grammar in line 144 is correct. Both variants should be correct, but have a different meaning.
Jonas-Kirchhoff
approved these changes
Sep 16, 2025
Erikhu1
added a commit
that referenced
this pull request
Nov 14, 2025
* generate list of issues with label containing 'bug' * check if repo reachable * add title and subtitles * expand file description * fix grammar error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a file "TSF/misbehaviours.md" in the branch save_historical_data containing a list of issues from nlohmann/json satisfying the following criteria:
OR
If no open issues, file is still overwritten:
If target repo (nlohmann/json) is unreachable, abort and fail workflow: