Conversation
f8f70e8 to
7998211
Compare
TSF/scripts/capture_test_data.py
Outdated
| command = ( | ||
| "CREATE TABLE IF NOT EXISTS test_results(", | ||
| "timestamp INT, " # when the test-run was started | ||
| "timestamp INT, " # NEEDS TO BE REMOVED!!! # when the test-run was started |
There was a problem hiding this comment.
Thank you, this comment from development is un-necessary and must be removed.
| run: | | ||
| mkdir test_report | ||
| mv TestResults.db test_report/TestResults.db | ||
| mv MemoryEfficientTestResults.db test_report/MemoryEfficientTestResults.db |
There was a problem hiding this comment.
what's the difference between "MemoryEfficientTestResults.db" and "MemoryEfficientTestResultData.db"? Why the need for both?
There was a problem hiding this comment.
The difference between the two data-bases is their role: MemoryEfficientTestResultData.db takes over the role of TestResultData.db as the persistent storage of test results, while MemoryEfficientTestResults.db takes the role of TestResults.db as the most recent test report. The latter is not persistently stored, but given to the artifact of the ubuntu workflow. In particular in case that TestResultData.db becomes large, this is more memory efficient than storing the former as artifact.
TSF/scripts/capture_test_data.py
Outdated
| @@ -230,7 +230,7 @@ def get_all_xml_files(directory: str = '.') -> list[str]: | |||
| "failed_cases INT, ", # number of failed test-cases | |||
| "skipped_cases INT, ", # number if skipped test-cases | |||
There was a problem hiding this comment.
typo in comment: number of skipped test-cases
Erikhu1
left a comment
There was a problem hiding this comment.
Please fix merge conflict in JLS-22.
* adapt report-names * fix indentation style * add more memory-efficient test-data capturer * add a bit of documentation * adapt references to use new test-report * adapt ubuntu workflow * adapt test to changed reference * rename non-existing column "skipped assertions" to correct name "failed assertions" * identify tests uniquely * fix typo in comments * update reference using the persistent data storage * Merge origin/main into rework_data_storage
rework test data storage and capture