Merged
Conversation
Jonas-Kirchhoff
commented
Sep 25, 2025
Jonas-Kirchhoff
commented
- add tests for custom scripts
- add validator checking existence of files
- add references and score to JLS-18, JLS-20 and JLS-22
Erikhu1
reviewed
Sep 25, 2025
.dotstop_extensions/validators.py
Outdated
| exceptions = [] | ||
| for file in files: | ||
| if not os.path.exists(file): | ||
| exceptions.append(RuntimeError("Critical Error: The path {file} does not exist.")) |
Collaborator
There was a problem hiding this comment.
not formatted as an f-string
TSF/scripts/clean_trudag_output.py
Outdated
|
|
||
| def insert_line(filepath): | ||
| """Insert a new line '### Compliance for Trustable Tenets' after '## Compliance for TT' in the file.""" | ||
| """Insert a new line explaining the abbreviation after '## Compliance for ABBR' in the trustable report.""" |
* put f-string instead of string * remove possible division by zero
Erikhu1
approved these changes
Sep 26, 2025
Erikhu1
pushed a commit
that referenced
this pull request
Nov 14, 2025
* add tests for custom scripts * add file-existence-checker * assert that unit-tests are executed daily * assert that historical scores are collected * assert that test-results are captured * remove un-necessary existence check * fix faulty configuration for evidence * fix file_exists validator * put f-string instead of string * remove possible division by zero * clarify place-holder ABBR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.