Merged
Conversation
* primary key in table test_results fails if update happens * most recent results still identifiably using table workflow_info
* order of argument in SQL-query was wrong * Necessity to update was detected erroneously
github-actions
bot
added
documentation
Author
|
This branch should be merged to main only after the branch save_historical_data_JK is merged into save_historical_data. This guarantees that the saving of test-results does not fail due to the violated uniqueness-constraint even in the un-expected case that any test fails. |
Erikhu1
approved these changes
Oct 6, 2025
TSF/scripts/README.md
Outdated
|
|
||
| * It is expected, that an update of a test-result only happens, when a test fails, which leads automatically to the failure of the pipeline, which should trigger a manual review by the maintainer, or failed before. | ||
| * It is expected, that tests fail rarely, and in particular on average less than 10 different test-cases per workflow-run fail. | ||
| * It is expected, that less than 1,000 worflow runs, where a record of the test-result is triggered, happen per year, since these are only triggered once daily and on each push to main. |
Collaborator
There was a problem hiding this comment.
typo: worflow --> workflow
Erikhu1
pushed a commit
that referenced
this pull request
Nov 14, 2025
* fix indentation style * fix typo in comments * Remove un-necessary primary key * primary key in table test_results fails if update happens * most recent results still identifiably using table workflow_info * Fix find_most_recent_results * order of argument in SQL-query was wrong * Necessity to update was detected erroneously * add heuristic size-check * document heuristic size-check * fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two mistakes are fixed:
Additionally, a heuristic size check is added and documented.