Skip to content

fixes for zig 0.14.0#12

Merged
scottredig merged 11 commits intoscottredig:mainfrom
dasimmet:main
Mar 10, 2025
Merged

fixes for zig 0.14.0#12
scottredig merged 11 commits intoscottredig:mainfrom
dasimmet:main

Conversation

@dasimmet
Copy link
Contributor

@dasimmet dasimmet commented Dec 26, 2024

No description provided.

@scottredig scottredig changed the base branch from main to 0.14 January 12, 2025 20:26
@scottredig
Copy link
Owner

scottredig commented Jan 12, 2025

I wasn't sure how I wanted to handle this pr. 0.14 isn't out yet, so I don't want to move main to relying on its breaking changes. For now, since you're the only one actively sending PRs for a bit and it seems you're on 0.14, I've created a new branch for 0.14. However I don't want to confirm all development on this repo will stay in sync with master past 0.14.

Please verify and confirm that both examples fully work after this PR.

scottredig
scottredig requested changes Jan 12, 2025
View reviewed changes
@dasimmet dasimmet changed the title fixes for zig 0.14.0-dev.2545+e2e363361 fixes for zig 0.14.0 Mar 8, 2025
@scottredig scottredig changed the base branch from 0.14 to main March 10, 2025 08:18
@scottredig scottredig mentioned this pull request Mar 10, 2025
Open
@scottredig
Copy link
Owner

scottredig commented Mar 10, 2025

The example doesn't work currently.
I fixed a couple issues with it, but encountered a regression in Zig. I've filed a bug report, will deal with making a workaround later.

scottredig
scottredig approved these changes Mar 10, 2025
View reviewed changes
Copy link
Owner

@scottredig scottredig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Fixed the issues with the examples. Please ensure they fully work in future PRs.

@scottredig scottredig merged commit 520c365 into scottredig:main Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scottredig scottredig scottredig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dasimmet @scottredig