Hotfix encoding issue#121
Closed
erip wants to merge 3 commits intoscrapinghub:masterfrom
erip:hotfix/encoding-issue
Closed
Hotfix encoding issue#121erip wants to merge 3 commits intoscrapinghub:masterfrom erip:hotfix/encoding-issue
erip wants to merge 3 commits intoscrapinghub:masterfrom
erip:hotfix/encoding-issue
Conversation
Author
|
cc @kmike - hopefully this can land in 0.9.8. Let me know if there's anything I can do to help that along. 😄 |
Author
|
I also wonder if this brings into question the desire to maintain python 2 support. Send it's officially EOL, do we want to remove it from CI? It would probably simplify the code quite a lot... that seems to be the issue with tests currently. |
|
I have the same issue here, I 've found the problem is |
|
Any updates on this PR? |
Contributor
|
thank you. closed with 4014eb0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #96 and #106