modernize code and packaging, and make package installable from cython source#165
Merged
modernize code and packaging, and make package installable from cython source#165
Conversation
Contributor
Author
|
@kmike if you care to take a look, I'll leave this open for a few days. otherwise, I'll go ahead and merge early next week. |
iwanb
added a commit
to iwanb/nixpkgs
that referenced
this pull request
Jan 4, 2025
Fixes build with GCC 14 thanks to scrapinghub/python-crfsuite#159 Requires building with Cython due to scrapinghub/python-crfsuite#165
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No substantive code changes, just tidying up things and improving the experience of installing from source.
One important difference is that the source distribution will no longer include a _pycrfsuite.cpp file. Instead it will just include the _pycrfsuite.pyx file. The pyproject.toml and setup.py have been adjusted to Cythonize that the extension at build time.
This also sets a minimum python of 3.8.