Skip to content

[test] Py3 porting#60

Closed
nyov wants to merge 1 commit intoscrapinghub:masterfrom
nyov:py3
Closed

[test] Py3 porting#60
nyov wants to merge 1 commit intoscrapinghub:masterfrom
nyov:py3

Conversation

@nyov
Copy link

@nyov nyov commented Mar 4, 2016

Some py3 changes.
Fixed this only enough to make scrapylib tests pass for me.
In particular I'm not sure if this should import to_native_str from scrapy for urlpathjoin.

Can't run the test-suite locally, so someone else with access to the remote scrapinghub endpoints please take over.

@nyov
Copy link
Author

nyov commented Mar 4, 2016

@bertinatto, I gathered that. Would be a bit heavy for a single utility function (or three). But it was the quickest way to get the tests to pass :P
Hope the PR may serve as inspiration to someone else to do better.

This work only happened to get scrapylib tests to pass for now: scrapinghub/scrapylib#71 (comment)

@chekunkov
Copy link
Contributor

IMO we shouldn't use scrapy

right

anyways, thanks for the contribution @nyov. Do you want to continue working on this PR or we can use it as a base for further Python 3 porting?

@nyov
Copy link
Author

nyov commented Mar 4, 2016

Please do use it as a base.. I cannot run the tests locally it seems (as I wrote earlier), so that would be too much shooting in the dark for me :)
Thanks!

(But don't thank me for the half-assed PR. It's more to raise awareness that this is a blocker for scrapylib py3 tests.)

@bertinatto
Copy link
Contributor

Closing PR because #62 was merged. Thank you, @nyov!

@bertinatto bertinatto closed this May 11, 2016
@nyov
Copy link
Author

nyov commented May 11, 2016

Awesome. Thanks for that.

@nyov nyov deleted the py3 branch May 11, 2016 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants