Fix unit tests by setting botgroup's max_running#64
Conversation
tests/hstestcase.py
Outdated
| for botgroup in cls.testbotgroups: | ||
| # Settings | ||
| # endpoint wouldn't accept list > 1 | ||
| cls.project.settings.apipost(jl={'botgroups': [botgroup]}) |
There was a problem hiding this comment.
what are you trying to achieve by setting project's botgroup to each of the testbotgroups sequentially? why do you need many of them?
There was a problem hiding this comment.
Setting more than one botgroup at once returns a 400 status code. However, many of these botgroups are no longer needed after the last changes.
There was a problem hiding this comment.
i mean running cls.project.settings.apipost(jl={'botgroups': [botgroup]}) for each botgroup is unnecessary, as each subsequent operation overrides the output of the previous one.
9dd9ee1 to
c049601
Compare
|
Please, have a look. Thanks. |
|
i have. could you please answer the questions in my comment? |
|
Done! Thanks. |
47a20dc to
afaada9
Compare
Sorry, it was a misunderstanding. @immerrr clarified that recently we ditched the possibility to set multiple botgroups per project. As a result, sequential settings ¹ |
|
LGTM |
Addresses #63.