Skip to content

Fix unit tests by setting botgroup's max_running#64

Merged
immerrr merged 4 commits intomasterfrom
fix_unit_tests
Apr 4, 2016
Merged

Fix unit tests by setting botgroup's max_running#64
immerrr merged 4 commits intomasterfrom
fix_unit_tests

Conversation

@bertinatto
Copy link
Contributor

Addresses #63.

for botgroup in cls.testbotgroups:
# Settings
# endpoint wouldn't accept list > 1
cls.project.settings.apipost(jl={'botgroups': [botgroup]})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are you trying to achieve by setting project's botgroup to each of the testbotgroups sequentially? why do you need many of them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting more than one botgroup at once returns a 400 status code. However, many of these botgroups are no longer needed after the last changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean running cls.project.settings.apipost(jl={'botgroups': [botgroup]}) for each botgroup is unnecessary, as each subsequent operation overrides the output of the previous one.

@bertinatto
Copy link
Contributor Author

Please, have a look. Thanks.

@immerrr
Copy link
Contributor

immerrr commented Apr 4, 2016

i have. could you please answer the questions in my comment?

@immerrr immerrr assigned bertinatto and unassigned immerrr Apr 4, 2016
@bertinatto bertinatto assigned immerrr and unassigned bertinatto Apr 4, 2016
@bertinatto
Copy link
Contributor Author

Done! Thanks.

@bertinatto
Copy link
Contributor Author

i have. could you please answer the questions in my comment?

Sorry, it was a misunderstanding.

@immerrr clarified that recently we ditched the possibility to set multiple botgroups per project. As a result, sequential settings POSTs ¹ won't append new botgroups. In the last push I addressed this.

¹ cls.project.settings.apipost(jl={'botgroups': [botgroup]})

@immerrr
Copy link
Contributor

immerrr commented Apr 4, 2016

LGTM

@immerrr immerrr merged commit 7857954 into master Apr 4, 2016
@immerrr immerrr deleted the fix_unit_tests branch April 4, 2016 16:22
This was referenced Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants