Make extension status button clickable on Windows Edge #1667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix a bug with the extension status button on windows edge: scratchfoundation#1660
…senbaum/scratch-blocks into ericrosenbaum-bugfix/edge-status-button
Contributor
Author
|
Update: thanks to a suggestion from @kchadha, moved the |
kchadha
approved these changes
Aug 1, 2018
Contributor
kchadha
left a comment
kchadha
left a comment
There was a problem hiding this comment.
LGTM -- @rachel-fenichel, I'm wondering if you have any thoughts on this PR?
Collaborator
|
(late) LGTM. I'm not super familiar with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #1660
Proposed Changes
Add
pointer-events: allto the flyout.Also, remove a duplicate css class.
Reason for Changes
The extension status button was not clickable on windows edge, because it was not receiving pointer events.
This change makes it work, and as far as I can tell does not have any other side effects (based on some quick testing on windows edge/chrome/firefox and mac chrome/firefox/safari).
Thanks to @technoboy10 and @kchadha for the help so far!
I'm not confident that this is the best fix (it would be great to make a more localized change). I'd love to have others have a look (e.g. @rachel-fenichel @paulkaplan).