RTL positioning for category labels and buttons in the flyout. #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var statusButtonX = (this.flyoutWidth_ - statusButtonWidth - marginX) / this.workspace_.scale; | ||
| var statusButtonX = this.workspace_.RTL ? (marginX - this.flyoutWidth_ + statusButtonWidth) : | ||
| (this.flyoutWidth_ - statusButtonWidth - marginX) / this.workspace_.scale; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
chrisgarrity
approved these changes
Aug 2, 2018
Contributor
chrisgarrity
left a comment
chrisgarrity
left a comment
There was a problem hiding this comment.
This is working as is, and all the other variations didn't get both the labels and the status into the correct positions.
|
|
||
| var statusButtonX = (this.flyoutWidth_ - statusButtonWidth - marginX) / this.workspace_.scale; | ||
| var statusButtonX = this.workspace_.RTL ? (marginX - this.flyoutWidth_ + statusButtonWidth) : | ||
| (this.flyoutWidth_ - statusButtonWidth - marginX) / this.workspace_.scale; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This was referenced Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #1584
Proposed Changes
Re-position category labels and buttons (including extension status button) in the toolbox when in RTL mode.
Reason for Changes
Localization.
Test Coverage
Manual testing in the vertical_playground as well as scratch-gui.
/cc @rachel-fenichel @AnmAtAnm