Add holding shift to force horizontal scrolling #263
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156.
This is a "workaround" for browsers which do not automatically set
deltaXwhen the shift key is held (seen on Firefox-Linux and Chrome-Windows, but not Chrome-Mac). This PR makes it so that when the shift key is held while scrolling,deltaXis ignored, and the distance scrolled horizontally is set todeltaY.This might have a strange effect on macbooks with trackpads (suddenly the distance you move your fingers left/right has no effect and horizontal scrolling is based on up/down finger movement), but I think that's acceptable - it would be obvious that it only behaves that way when shift is held, and wouldn't be too difficult to intuit anyways.
Tested locally on Firefox/Linux.