Convert all strings to Scribe-i18n keys

[andrewtavis]

Terms

• I have searched open and closed feature requests
• I agree to follow Scribe-Android's Code of Conduct

Description

As discussed in #94, changes in Scribe-i18n that just went through mean that we now have all the strings from the designs within the language i18n files. It would be great if we could update the Scribe-i18n subtree and then convert all strings in the application over to Scribe-i18n keys.

Contribution

Happy to review and support as needed!

[andrewtavis]

@angrezichatterbox, I'm also thinking that this one might make sense for you as this would allow you to check that I've added all of the strings you mapped out? Thoughts on picking this up? :)

[angrezichatterbox]

@angrezichatterbox, I'm also thinking that this one might make sense for you as this would allow you to check that I've added all of the strings you mapped out? Thoughts on picking this up? :)

Yes I'll work on this once #89 is done.

[andrewtavis]

Thanks, @angrezichatterbox! We'll be in a great place once this and #89 are done :) :)

[angrezichatterbox]

Should I run the scripts for the conversion of the i18n strings to XML now or should it be done in the i18n and then pushed there as the current XML isn't updated according to the updated json. Is its updation done using the workflow?

[andrewtavis]

I think it's fine for you to run the scripts and send along a PR. I'll merge tonight and then work can begin on this tomorrow :)

[andrewtavis]

scribe-org/Scribe-i18n@5701774 just sent along the changes you suggested for Scribe-i18n, @angrezichatterbox :) Maybe we can close this issue via another minor edit to convert the last missing strings?