Removed about and settings from the top right

[henrikth93]

Removed about and settings from the top right of the menu.

Contributor checklist

• [] This pull request is on a separate branch and not the main branch

---

Description

Related issue

• #Remove Settings and About options from the top right of the installation tab #45

[github-actions]

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

• The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

  • The contributor's name and icon in remote commits should be the same as what appears in the PR
  • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[angrezichatterbox]

Scribe-Android/app/src/main/kotlin/be/scri/activities/MainActivity.kt

Lines 110 to 124 in abfea22

	override fun onCreateOptionsMenu(menu: Menu): Boolean {
	menuInflater.inflate(R.menu.menu_main, menu)
	updateMenuItemColors(menu)
	return true
	}
	override fun onOptionsItemSelected(item: MenuItem): Boolean {
	when (item.itemId) {
	R.id.settings -> launchSettings()
	R.id.info -> launchAbout()
	else -> return super.onOptionsItemSelected(item)
	}
	return true
	}

These two functions can be removed as they are no longer required since the top menu has been removed.

[angrezichatterbox]

This file could be removed as it is no longer required. and as the references of id have been renamed to R.id.info.

[andrewtavis]

Thanks for the review, @angrezichatterbox! Let us know if you have any questions, @henrikth93 :)

[henrikth93]

Thanks for the review, @angrezichatterbox! Let us know if you have any questions, @henrikth93 :)

Updated the code now.

[andrewtavis]

Welcome to the Scribe-Android contributors, @henrikth93! 🎉 Thanks so much for this,a and looking forward to the next PR where we get the Scribe logo in! Will start feeling a lot more familiar then 😊