Conversation
Thank you for the pull request! 💙🩵The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
Can you take a look at the merge conflicts, @Femimat? Let us know when this is ready for a review :) |
|
Hi @andrewtavis, thanks for the heads up! I’m currently working on resolving the merge conflicts and will let you know once it’s ready for review. |
|
Hi @andrewtavis, you can review the PR now. |
|
Sounds good, @Femimat! Thanks for resolving the conflicts 😊 |
DeleMike
left a comment
There was a problem hiding this comment.
LGTM too. Can you share with me the time it takes now?
Earlier, the instrumentation tests usually took between 12 to 15 minutes
|
Hi @DeleMike, The tests now run in parallel: Conjugate took 7m and Keyboards took 13m. This brings the total wall-clock time down to 13 minutes, while providing much faster feedback for the first flavor. ci_android / build app (pull_request) |
DeleMike
left a comment
There was a problem hiding this comment.
Thank you so much @Femimat!
I understand there may be minor factors affecting the speed of these tests. However, I feel like an average of 10-12 minutes is fair.
Actually, when you physically do an instrumentation test, they take around the same time, if not longer.
Unless someone has other ideas, everything looks good here.
@angrezichatterbox, what do you think?
cc: @andrewtavis
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
Renamed the "Run Ktlint" step in the test job to "Run Unit Tests" to accurately reflect that it runs ./gradlew test.
Adjusted timeout-minutes to a more appropriate 45 minutes per parallel job.
Investigate and speed up Android instrumentation tests #580