feat: add Conjugate app download data UI (#564)#603
Open
Mounil2005 wants to merge 2 commits intoscribe-org:mainfrom
Open
feat: add Conjugate app download data UI (#564)#603Mounil2005 wants to merge 2 commits intoscribe-org:mainfrom
Mounil2005 wants to merge 2 commits intoscribe-org:mainfrom
Conversation
Shows all supported languages alphabetically instead of only installed keyboard languages, using shared components with the keyboard app. Signed-off-by: Mounil Kanakhara <mounilkankhara@gmail.com>
Thank you for the pull request! 💙🩵The Scribe-Android team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
54e228c to
f63221f
Compare
Signed-off-by: Mounil Kanakhara <mounilkankhara@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR adds the download data UI for the Scribe-Conjugate app.
Files changed:
app/src/main/java/be/scri/ui/screens/download/ConjugateDownloadDataScreen.kt(new) - A new screen that displays all 8 supported languages (English, French, German, Italian, Portuguese, Russian, Spanish, Swedish) sorted alphabetically. Unlike the keyboard app's download screen which only shows installed keyboards, this screen always shows all languages. It reuses shared components (LanguageItemComp,CircleClickableItemComp,SwitchableItemComp) and shared data classes (DownloadActions,CheckUpdateActions,LanguageItem) from the keyboard app. There is no empty state and no translation source language confirmation dialog, as these are keyboard-specific features.app/src/main/java/be/scri/App.kt- Added a new"conjugate_download_data"navigation route wired toConjugateDownloadDataScreen, and updatedConjugateScreen'sonNavigateToDownloadDatato use this route instead of the keyboard app's"download_data"route.Related issue