This repository was archived by the owner on Oct 20, 2024. It is now read-only.
Added logic to insert whitespace after NOT operators#6
Open
shawcohn wants to merge 1 commit into
Open
Conversation
Owner
There was a problem hiding this comment.
That's a pretty strange echo. Debugging artifact?
Owner
|
Can you post a few "before and after" examples of this new behavior? |
Owner
|
Actually, I think this would be a good time to introduce some phpunit tests that cover all the branches touched by the pull request: T_IF, T_WHILE etc. |
Owner
|
I know that, compared to implementing a new feature, writing tests seems like a chore, but it's necessary, particularly for such a script, with many many branches. If you're not familiar with PHPUnit, just give me the test cases, i.e. "this bit of incorrect PHP should look like this after I run it through wp-phptidy", I'll translate them to working PHPUnit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for adding space after NOT operators to conform with the WordPress PHP Coding Standards. See the section on logical comparisons under spacing: https://make.wordpress.org/core/handbook/coding-standards/php/#space-usage