Added support for setting parameters via command-line arguments, and …#1
Open
bravelocation wants to merge 2 commits intoscripting:masterfrom
Open
Added support for setting parameters via command-line arguments, and …#1bravelocation wants to merge 2 commits intoscripting:masterfrom
bravelocation wants to merge 2 commits intoscripting:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…for running once only
I made this change because on my shared host server I can only run cron jobs, so I didn't want it to run continuously.
Basically using the nconf library means you can use either environment variables or command-line arguments to the script to set the various parameters.
I also added a "runEveryMinute" parameter - defaulting to true to keep original behaviour - that can be set to false which will run the code only once and then exit the script.
Your script saved me a lot of time, so am happy to contribute my minor changes if you think other people may find them useful (and definitely feel free to ignore them if you don't!)
Thanks
John Pollard