-
Notifications
You must be signed in to change notification settings - Fork 40
Update BaseFold number of queries to 200 according to the recent papers. #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| impl RSCodeSpec for RSCodeDefaultSpec { | ||
| fn get_number_queries() -> usize { | ||
| 972 | ||
| 200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put some links or comments here to justify the reduction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I'll copy from the original PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Theorem 1 of paper (https://eprint.iacr.org/2024/1571), the soundness error is bounded by
If we take
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change, I will try to verify with quick benchmark and report e2e result here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yczhangsjtu Could you make that explanation part of the code base, perhaps as a comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yczhangsjtu I try run benchmark on 2^20 which involve basefold commit/opening riscv_add
On ceno server, benchmark result shows no significant change before/after.
does it fit the expectation, or do you have any benchmark result for that change?
Just double check in case the change actually not take effect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should expect a big reduction of the proof size. @yczhangsjtu Can you give us how many bytes do we save after applying this PR?
Extracting small PRs from #294