Skip to content

Conversation

@yczhangsjtu
Copy link
Collaborator

@yczhangsjtu yczhangsjtu commented Nov 4, 2024

Extracting small PRs from #294

impl RSCodeSpec for RSCodeDefaultSpec {
fn get_number_queries() -> usize {
972
200
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put some links or comments here to justify the reduction?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I'll copy from the original PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Theorem 1 of paper (https://eprint.iacr.org/2024/1571), the soundness error is bounded by $O(1/|F|) + (\sqrt{\rho}+\epsilon)^s$ where $s$ is the query complexity and $\epsilon$ is a small value that can be ignored. So the number of queries can be estimated by

$$ \frac{2\lambda}{-\log\rho} $$

If we take $\lambda=100$ and $\rho=1/2$, then the number of queries is $200$.

Copy link
Collaborator

@hero78119 hero78119 Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, I will try to verify with quick benchmark and report e2e result here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yczhangsjtu Could you make that explanation part of the code base, perhaps as a comment?

Copy link
Collaborator

@hero78119 hero78119 Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yczhangsjtu I try run benchmark on 2^20 which involve basefold commit/opening riscv_add
On ceno server, benchmark result shows no significant change before/after.
does it fit the expectation, or do you have any benchmark result for that change?
Just double check in case the change actually not take effect

Copy link
Collaborator

@kunxian-xia kunxian-xia Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should expect a big reduction of the proof size. @yczhangsjtu Can you give us how many bytes do we save after applying this PR?

@yczhangsjtu yczhangsjtu merged commit a4378cd into master Nov 4, 2024
@yczhangsjtu yczhangsjtu deleted the feat/basefold-refactor-extract-0 branch November 4, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants