Remove Rng from PCS type paramter.
#549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasgoergens
approved these changes
Nov 5, 2024
Contributor
matthiasgoergens
left a comment
matthiasgoergens
left a comment
There was a problem hiding this comment.
Thanks for breaking this off into a simple and easily reviewable PR.
kunxian-xia
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting a small PR from #294.
The random generator is used only when the encoding scheme is Basecode, and not used for RS code. So remove it from the type parameter for Basefold, i.e.,
Basefold<E, Spec, Rng>is replaced withBasefold<E, Spec>to make the API simpler. Fix it toChaCha8Rngin the implementation of Basecode.