Refactor BaseFold test code #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasgoergens
approved these changes
Nov 25, 2024
Contributor
matthiasgoergens
left a comment
matthiasgoergens
left a comment
There was a problem hiding this comment.
Looks ok in general, but please have a look at my comments. Thanks!
mpcs/src/basefold.rs
Outdated
| // Both challenge and poly are over base field | ||
| run_batch_commit_open_verify::<GoldilocksExt2, PcsGoldilocksRSCode>(true, 10, 11); | ||
| fn commit_open_verify_goldilocks() { | ||
| for base in [true, false].into_iter() { |
Contributor
There was a problem hiding this comment.
Small cosmetic suggestion:
Suggested change
| for base in [true, false].into_iter() { | |
| for base in [true, false] { |
(Similar for the other loops, too.)
|
|
||
| pub fn gen_rand_poly<E: ExtensionField>( | ||
| num_vars: usize, | ||
| base: bool, |
Contributor
There was a problem hiding this comment.
Didn't we have a PR where we moved away from using booleans here (and in similar situations)?
Contributor
There was a problem hiding this comment.
Hmm, I guess that's happening in the follow up PR?
Collaborator
There was a problem hiding this comment.
@yczhangsjtu feel free either to resolve coversation (so i can merge) or change some code.
yczhangsjtu
added a commit
that referenced
this pull request
Nov 28, 2024
Extracting small PR from #294. The two benchmarks `benches_commit_verify_rs` and `benches_commit_verify_basecode` are similar, differing only in the choice of parameter. Merge them into one benchmark file. Also simplify the codes using the test utility functions introduced in #552 Waiting for #552 to merge. --------- Co-authored-by: Matthias Görgens <matthias.goergens@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting small PR from #294
Refactor the test code in
mpcs/src/lib.rs. Define some utility functions to simplify the tests.Also merged the test functions in
mpcs/src/basefold.rs.