Skip to content

Conversation

@hero78119
Copy link
Collaborator

This PR just add tracing span to measure the mpcs break down and visualized in flamegraph

Also attachmented framegraph (its svg file and please download it local then open in browser which allow iteractive navigating)
flamegraph

The bottleneck part probably not on sumcheck, and instead it's from compute_inner_ext and root_from_inner operation

running_tree_inner = MerkleTree::<E>::compute_inner_ext(&new_running_oracle);
let running_root = MerkleTree::<E>::root_from_inner(&running_tree_inner);
write_digest_to_transcript(&running_root, transcript);
exit_span!(inner_span);

@hero78119 hero78119 marked this pull request as draft November 6, 2024 17:21
@hero78119
Copy link
Collaborator Author

related to #568

@naure naure requested a review from mcalancea November 6, 2024 19:12
@hero78119
Copy link
Collaborator Author

hero78119 commented Nov 7, 2024

More added on: the latency breakdown

  • 75% time on mpcs
  • 25% time on opcode/table sumckeck proof

So optimize mpcs at current stage will be more huge gain.

In another follow up #537 (comment) the improvement only <15% overall is because it only affect opcode proof sumcheck part. mpcs got another sumcheck implementation and we plan to merge it in issue #558

In overall, as mpcs occupied more time (til 7 Nov '24), any improvement on mpcs will have better impact on overall throuput.

@hero78119
Copy link
Collaborator Author

Closed in favor of new mpcs implementation.

@hero78119 hero78119 closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants