Suggestions for 'Merge two similar benchmarks in BaseFold into one' #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasgoergens
commented
Nov 8, 2024
| // unfortunately integration benchmarks do not compile the #[cfg(test)] | ||
| // code. So remove the gate for the entire module, only gate the test | ||
| // functions. | ||
| // TODO(Matthias): use cfg(or(test, bench)) or something like that. |
Contributor
Author
There was a problem hiding this comment.
Ignore this one. :)
matthiasgoergens
force-pushed
the
matthias/feat/basefold-refactor-extract-1
branch
from
9397b06 to
0dca126
Compare
yczhangsjtu
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.