Skip to content

Conversation

@hero78119
Copy link
Collaborator

@hero78119 hero78119 commented Apr 1, 2025

Follow up on #843
Clean up basefold sumcheck and unified devirgo sumcheck with ceno.
Previously in #653 before/after change is insignificant, but after bunch of refactor and optimised other critical path, now the benchmark shows promising result.

Change highlights

  • switch to ceno sumcheck and break down basefold sumcheck into 2 phases

    we can't directly use ceno sumcheck as blackbox because of FRI part in basefold.

  • and use evaluation form as uni-variates
  • clean up old sumcheck impl

benchmark

With e2e
Fibonacci 2^20

fibonacci_max_steps_1048576/prove_fibonacci/fibonacci_max_steps_1048576
                        time:   [3.1789 s 3.2022 s 3.2274 s]
                        change: [-14.457% -13.632% -12.780%] (p = 0.00 < 0.05)
                        Performance has improved.

Fibonacci 2^21

fibonacci_max_steps_2097152/prove_fibonacci/fibonacci_max_steps_2097152
                        time:   [5.2820 s 5.3010 s 5.3207 s]
                        change: [-16.128% -15.753% -15.306%] (p = 0.00 < 0.05)
                        Performance has improved.

Fibonacci 2^22

fibonacci_max_steps_4194304/prove_fibonacci/fibonacci_max_steps_4194304
                        time:   [10.369 s 10.397 s 10.423 s]
                        change: [-10.485% -10.041% -9.5790%] (p = 0.00 < 0.05)
                        Performance has improved.

@hero78119 hero78119 force-pushed the feat/basefold_cleanup branch from d986984 to b8d135c Compare April 1, 2025 15:07
@kunxian-xia kunxian-xia self-requested a review April 2, 2025 05:18
Copy link
Collaborator

@kunxian-xia kunxian-xia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except a few nitpicks and transcript writes.

@hero78119 hero78119 force-pushed the feat/basefold_cleanup branch from e8a3ccc to 6dcd431 Compare April 3, 2025 07:02
@kunxian-xia kunxian-xia added this pull request to the merge queue Apr 3, 2025
Merged via the queue into scroll-tech:master with commit 99a2787 Apr 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants