Conversation
* add trait to PrecompilesStruct and refactor * impl sha * add execute method and execute using Crypto trait * refactor tests * fmt * reduce diff * fix * fmt * add box * benchmarks * fmt * add ripemd
Without this attribute, debug info will point into the macro, but this is quite annoying when debugging/profiling. e.g. `gas!` will show up in a separate stack frame in `samply`. Reference: https://doc.rust-lang.org/nightly/reference/attributes/debugger.html#r-attributes.debugger.collapse_debuginfo
Having rust-version set helps Cargo produce better error messages if the installed version is lower than the minimum specified.
Same format as all the others. The name actually matters for the bench workflow to skip building.
* add bn128 * add rest of impls * add cfg_if * uniform reexport * refactor * nit: function names * remove refs from blake * type alias + inlines * use trait for version hash * remove Result * test dynamic dispatch * revert static call * chore: reuse global crypto provide idea * fix compilation * add default impl to Crypto trait * nit rm alloc * nits * fix lock compilation * return bool for p256 verify fn --------- Co-authored-by: Kevaundray Wedderburn <kevtheappdev@gmail.com>
Makes `Result<(), InstructionResult>::Ok(())` equal 0.
0 as a value is cheaper on certain architectures to return from a
function and/or to branch off of (e.g. `if is_ok() { ... }`).
* Fix bug, system tx not enveloped and add test * Fix lint
…loy#2810) * feat: rename bn128 to bn254 for Ethereum standard consistency * fix: renamed more occurences * fix: addresed nits
* Fix typos * Cover OpTransactionError::Base in test display * fixup! Fix typos
* att1 * cargo fmt * reduce test bloat * remove InspectSystemCallCommitEvm * fix: rename system call inspection methods to match inspect_one_tx pattern - inspect_system_call_one -> inspect_one_system_call - inspect_system_call_with_caller_one -> inspect_one_system_call_with_caller - inspect_system_call_with_inspector_one -> inspect_one_system_call_with_inspector * feat: add system call inspection support to op-revm - Implement InspectSystemCallEvm trait for OpEvm - Add inspect_one_system_call_with_caller method - Add comprehensive test for system call inspection functionality * fix: simplify system call inspection test - Remove unnecessary custom bytecode setup - Use default context for cleaner test * style: fix code formatting for CI - Format import statements in exec.rs - Fix whitespace formatting in test functions - Ensure consistent code style across files * trigger ci * Revert "trigger ci" This reverts commit fba9ceb.
* feat: refactor test utils * fix compilation * feat: add ee-test to unify ee tests * sort all json test fixtures * fmt * typo
…ts (bluealloy#2815) * Adds handler test for verifying unchanged nonce on balance too low revert * Fix system call test * fixup! Fix merge conflicts
…luealloy#2816) * feat: removed padding in case last opcode is terminating or unknown * fix: clippy lint error * fix: fmt error * feat: refactored the functions * feat: added assert statement to check for terminating opcodes * feat: added test to check last bytecode byte is terminating
- Currently in foundry we check for None OR hash==zero to check if it's unset. Use `None` in all cases. - Provide a helper for `get_or_insert_with()` that calculates the hash if unset.
…compile (bluealloy#2809) * initial code * fix: cfg * add blst * one function for pairing * make arkworks look like blst * cleanup, reuse fn from blst/arkwork, fix kzg blst scalar check. Enable kzg * doc links * nit cleanup
Calling `set_action` when an action is already set usually means that a previous `halt` or similar was not returned.
- Remove unwrap() in primitives::short_address by using direct array indexing - Use lazy allocation with or_insert_with to avoid unnecessary Vec allocations - Pre-allocate Vec capacity in State::increment_balances based on iterator hint - Simplify iterator pattern in bundle_state to use destructuring - Use mem::take instead of mem::replace for bool values - Add #[inline] attributes to small hot-path functions in state module - Use unwrap_or_default() instead of unwrap_or(0) for cleaner code These are small incremental improvements that enhance performance and code safety without changing functionality.
…loy#2874 (bluealloy#2876) - PR bluealloy#2866: Fix comment reference from calc_excess_blob_gas to calc_excess_blob_gas_osaka - PR bluealloy#2867: Remove debug macro from test code in inspector lib - PR bluealloy#2874: Replace len() == 0 with is_empty() for idiomatic Rust 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <noreply@anthropic.com>
…loy#2816)" (bluealloy#2883) * Revert "feat: removed padding in case last opcode is terminating or unknown (bluealloy#2816)" This reverts commit 5f67c14. * clippy and rm tests * doc comment changed
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* test: add AccountStatus unit test * update
Co-authored-by: megakabi <jakevin@megatechnology.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
frisitano
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked all commits and only this one touches the handler, which doesn't have an impact for us.