Skip to content

remove scs node-template dependency#174

Merged
clangenb merged 1 commit intomasterfrom
cl-remove-custom-node-dependency
Nov 3, 2021
Merged

remove scs node-template dependency#174
clangenb merged 1 commit intomasterfrom
cl-remove-custom-node-dependency

Conversation

@clangenb
Copy link
Collaborator

@clangenb clangenb commented Nov 3, 2021

Closes #165.

This was such a low-hanging fruit that I just needed to tackle it.

@haerdib can you update jenkins to use the node-template from substrate instead?

@clangenb clangenb requested a review from haerdib November 3, 2021 04:00
@clangenb
Copy link
Collaborator Author

clangenb commented Nov 3, 2021

@haerdib I think we can merge this one as is. I prefer not to invest work into jenkins anymore, and the tests pass there currently. We should rather tackle #176 soon.

Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with #176 :)

@clangenb clangenb merged commit 11aafee into master Nov 3, 2021
@clangenb clangenb deleted the cl-remove-custom-node-dependency branch November 10, 2021 10:53
@haerdib haerdib added the E0-silent Will not be mentioned in the release label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

E0-silent Will not be mentioned in the release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop custom substrate-api-client-test-node pendency.

2 participants