Remove unused default value in StorageMaps to allow OptionQuery#210
Merged
Remove unused default value in StorageMaps to allow OptionQuery#210
Conversation
clangenb
reviewed
Feb 8, 2022
Collaborator
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
Looks so far good to me.
So, is there a difference now in how you call an OptionQuery map or an ValueQuery? If yes, it would be valuable to have that documented somewhere
Contributor
Author
|
No, there is no difference, actually. With the removal of the default value, it retrieves the optional storage value perfectly without any changes on the client side. |
clangenb
approved these changes
Feb 8, 2022
Collaborator
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
Cool, then I approve as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unused default value from the StorageMaps. It was not used and blocked OptionQueries by throwing
MapValueTypeErrors when querying an Option Value.Tested with recent node and worker (integritee-network/worker#645)