ci: use only pre-commit for type checks#306
Merged
flying-sheep merged 3 commits intomainfrom Nov 19, 2025
Merged
Conversation
flying-sheep
changed the title
grst
approved these changes
Nov 19, 2025
Comment on lines
+73
to
+79
| additional_dependencies: | ||
| - httpx | ||
| - types-jsonschema | ||
| - pillow | ||
| - pygithub | ||
| - types-PyYAML | ||
| - rich |
Contributor
There was a problem hiding this comment.
there's no way to get this from pyproject.toml I guess?
Member
Author
There was a problem hiding this comment.
Nope! Either you have mypy in pre-commit (with this) or you don’t have mypy in pre-commit.
It might be possible that there is a typecheck hook that downloads the necessary dependencies, but I don’t know.
Contributor
There was a problem hiding this comment.
Would it be absurd to use lang: system together with hatch run? But probably that falls apart on pre-commit-ci
Member
Author
There was a problem hiding this comment.
But probably that falls apart on pre-commit-ci
exactly!
Member
Author
There was a problem hiding this comment.
I found this, which could be worth investigating: https://github.com/H4rryK4ne/update-mypy-hook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn’t realize that this
probablyworks!