fix: Have sum operate on the passed dtype.#125
Merged
flying-sheep merged 13 commits intomainfrom Oct 15, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
- Coverage 98.32% 98.32% -0.01%
==========================================
Files 17 17
Lines 419 418 -1
==========================================
- Hits 412 411 -1
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #125 will not alter performanceComparing Summary
|
ilan-gold
reviewed
Oct 13, 2025
Contributor
ilan-gold
left a comment
ilan-gold
left a comment
There was a problem hiding this comment.
Do you really want me to review this @flying-sheep ? The tests seem quite broken?
Member
Author
|
We talked about how to handle it already, so I think we’re good for now! |
flying-sheep
changed the title
sum precisionsum operate on the passed dtype.
Member
Author
|
now it’s ready! |
ilan-gold
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #124
discovered by @quentinblampey in #116 (comment)
super strange: why is the
cs{rc}_{matrix_array}result different than when using numpy?