Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
+ Coverage 96.87% 98.45% +1.58%
==========================================
Files 15 15
Lines 256 259 +3
==========================================
+ Hits 248 255 +7
+ Misses 8 4 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #51 will improve performances by ×2.9Comparing Summary
Benchmarks breakdown
|
ilan-gold
left a comment
There was a problem hiding this comment.
In general I'm getting a bit concerned about all the casting going on but since it's in pre-commit, it should be manageable from a us-reviewing-other-PRs perspective i.e., we can always just tell people to look at the output. I was a little worried that there was no CI around this
|
Casting? You mean mypy? I think mypy and Python’s type system are simply not that great. With TypeScript, I could rely on the type system saying the truth, but in Python it’s more often an error in the typing or a bug in mypy than my fault. Makes the whole ordeal of rather limited use tbh if one can’t rely on the type system. Maybe switching to PyRight could help. |
Fixes #3
Intended properties:
as_dense(to_memory=True)ofc