Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 98.91% 98.95% +0.03%
==========================================
Files 17 17
Lines 370 381 +11
==========================================
+ Hits 366 377 +11
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #84 will improve performances by ×4Comparing Summary
Benchmarks breakdown
|
flying-sheep
commented
Apr 24, 2025
Comment on lines
+55
to
+56
| if axis is None: | ||
| return cast("np.number[Any]", x.data.sum(dtype=dtype)) |
Member
Author
There was a problem hiding this comment.
without this, 1D csr_arrays sum up to np.float64 no matter if bool, int, or float32.
that’s not the case for 2D ones, so I should probably report this as an issue to scipy.
ilan-gold
reviewed
Apr 25, 2025
ilan-gold
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One thing we could do is making the
assert_array_equalsstrict=True.That’d require downcasting
float64tofloat32in some cases though.