Merged
Conversation
CodSpeed Performance ReportMerging #94 will not alter performanceComparing Summary
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
===========================================
- Coverage 98.27% 83.45% -14.83%
===========================================
Files 17 17
Lines 406 417 +11
===========================================
- Hits 399 348 -51
- Misses 7 69 +62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ilan-gold
approved these changes
May 5, 2025
Contributor
ilan-gold
left a comment
There was a problem hiding this comment.
Aside from a bit more info in the public API, looks good
Comment on lines
+58
to
+59
| order | ||
| The order of the output array: ``C`` (row-major) or ``F`` (column-major). ``K`` and ``A`` derive the order from ``x``. |
Contributor
There was a problem hiding this comment.
I would add more info here i.e., what you say in the PR comment
Member
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This diverges from e.g. scipy’s default behavior, because
_csbase.toarrayhas"C"as default, whereas numpy has"K"as default, and I think the behavior should be the same in both cases.Therefore CSC matrices become F-contiguous arrays when
order="K"(the default).Dask is problematic, because it doesn’t allow to specify order at all: It basically does what it wants, so we can’t really test for sane behavior.