Skip to content

🔥 cleanup #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbuttner merged 3 commits into from
Aug 15, 2022
Merged

🔥 cleanup #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba5298f
:fire: remove core template
mbuttner Aug 15, 2022
3c6cb79
:art: add plotdata to quickstart
mbuttner Aug 15, 2022
3163ed1
:bug: fix type
mbuttner Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion docs/tutorials/quickstart.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,17 @@
"metadata": {},
"outputs": [],
"source": [
"pm.pp.split_signal(adata)"
"pm.pp.split_signal(adata, var_key=\"channel\")"
]
},
{
"cell_type": "code",
"execution_count": null,
"id": "2b1204cf",
"metadata": {},
"outputs": [],
"source": [
"pm.pl.plotdata(adata)"
]
},
{
Expand Down
2 changes: 0 additions & 2 deletions pytometry/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,3 @@
from . import preprocessing as pp
from . import read_write as io
from . import tools as tl

# from ._core import ExampleClass, example_function # noqa
26 changes: 0 additions & 26 deletions pytometry/_core.py
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions pytometry/plotting/_histogram.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def plotdata(
" normalization."
)

if option_key not in ["area", "height", "other"]:
if option_key.lower() not in ["area", "height", "other"]:
print(f"Option {option_key} is not a valid category. Return all.")
datax = adata_.X
var_names = adata_.var_names.values
Expand All @@ -71,10 +71,10 @@ def plotdata(
number = len(names)

columns = 3
rows = np.ceil(number / columns)
rows = int(np.ceil(number / columns))

fig = plt.figure()
fig.subplots_adjust(hspace=0.4, wspace=0.6)
fig.subplots_adjust(hspace=0.8, wspace=0.6)

for idx in range(number):
ax = fig.add_subplot(rows, columns, idx + 1)
Expand Down