🐛 Small fix for bug in compensation function.#39
Conversation
|
Hi @ricomnl |
|
just did :) thanks for the pointer |
…d check if X has changed after compensation and log a warning if not
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 80.46% 80.41% -0.06%
==========================================
Files 10 10
Lines 384 388 +4
==========================================
+ Hits 309 312 +3
- Misses 75 76 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks for your contribution! I had to update the CI before I could merge the branch. |
|
awesome thanks! |
This PR fixes an issue that arises when no indices between the compensation matrix columns and the adatas index (or channel column) are intersecting. Previously this was not caught because
idx_in is Nonedoesn't check ifidx_inis empty and therefore not caught. I also added a check if X has changed after compensation and am logging a warning if it hasn't.