Xenium: cache zip store opening; vectorize cell id encoding#370
Open
LucaMarconato wants to merge 3 commits intomainfrom
Open
Xenium: cache zip store opening; vectorize cell id encoding#370LucaMarconato wants to merge 3 commits intomainfrom
LucaMarconato wants to merge 3 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
==========================================
+ Coverage 62.70% 62.78% +0.08%
==========================================
Files 27 27
Lines 3140 3147 +7
==========================================
+ Hits 1969 1976 +7
Misses 1171 1171
🚀 New features to boost your workflow:
|
Member
Author
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

After doing some profiling, I identified 2 bottlenecks:
cell_id_str_from_prefix_suffix_uint32()had some long for loops that could be removed.This PR:
cell_id_str_from_prefix_suffix_uint32()The second part is very interesting: Claude Opus 4.6 suggested a clever bit-shift trick which halves execution time (illustrated below, again with the help of Claude).
Further optimization could be explored for the string concatenation, which is now driving the runtime of the function (10% of total, see flame graph), and is among the top 3 drivers of runtime.
Flame graph:

Explanation of the bit shift trick:
