fix: remove unused parameters in co_occurence#1121
Merged
selmanozleyen merged 8 commits intoscverse:mainfrom Mar 11, 2026
Merged
fix: remove unused parameters in co_occurence#1121selmanozleyen merged 8 commits intoscverse:mainfrom
selmanozleyen merged 8 commits intoscverse:mainfrom
Conversation
for more information, see https://pre-commit.ci
Member
flying-sheep
left a comment
There was a problem hiding this comment.
this will break code that uses these parameters – sure they are unused, but you could warn first that they do nothing and will be removed, and then remove them later,
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1121 +/- ##
=======================================
Coverage 72.96% 72.96%
=======================================
Files 38 38
Lines 6484 6496 +12
Branches 1151 1153 +2
=======================================
+ Hits 4731 4740 +9
- Misses 1270 1272 +2
- Partials 483 484 +1
🚀 New features to boost your workflow:
|
39163ff to
583bdcb
Compare
selmanozleyen
added a commit
to selmanozleyen/squidpy
that referenced
this pull request
Mar 11, 2026
* remove the params * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * recommit * update nb --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #1110 and #1048 .
n_splits usage was removed here 32789ae