improvement(email_service): Add support for Generic Results API #865
Conversation
|
Demo: 
|
looks very similar to results tab :) |
There was a problem hiding this comment.
Pull request overview
This PR adds support for displaying Generic Results API data in email reports by introducing a new email section that renders performance, iotune, and other test results as formatted tables. The implementation includes a Jinja2 template for table rendering, CSS styling for result status colors, backend service integration with the Results API, and template filters for status-to-style mapping.
- Introduces the
GenericResultspartial class to fetch and filter test results from the Results API - Adds a new Jinja2 template with status-based cell coloring and conditional link rendering for HTTP values
- Updates documentation with configuration options for section naming and table filtering
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/email/partials/generic_results.html.j2 | New template for rendering generic result tables with column headers, row data, and status-based styling |
| templates/email/css/styles.css | Adds CSS classes for success, danger, warning, and secondary table cell states |
| argus/backend/service/email_service.py | Implements GenericResults partial class with result fetching and regex-based table filtering |
| argus/backend/template_filters.py | Adds result_status_to_table_cell filter to map status strings to CSS classes |
| docs/api_usage.md | Documents generic_results section with table_filter and section_name options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
k0machi
force-pushed
the
email-reporting-support-generic-results
branch
from
6db46ec to
9fdac3e
Compare
They do! Clicking them downloads them. |
This commit adds support for Generic Result tables inside email reports, allowing users to show performance, iotune and other results from SCT tests. Supported options: section_name and table_filter. Docs are updated with new options. Fixes scylladb#864
k0machi
force-pushed
the
email-reporting-support-generic-results
branch
from
9fdac3e to
68a22be
Compare
Nice, you think we could optionally embed them ? (pref under operations test was doing that) |
3 participants
This commit adds support for Generic Result tables inside email reports,
allowing users to show performance, iotune and other results from SCT
tests. Supported options: section_name and table_filter.
Docs are updated with new options.
Fixes #864