Conversation
…s resolved, spawning is now fully randomized for all object geometries
…nabled, some fair-play mechanic fixes, and competitive play completed
…nd some bug fixes.
… balances introduced (e.g. movespeed of players)
… more gameplay balances introduced (e.g. movespeed of players)
… more gameplay balances introduced (e.g. movespeed of players)
runnersaw
left a comment
runnersaw
left a comment
There was a problem hiding this comment.
You are missing instructions how to start the game, but you have a very good explanation of gameplay.
Your code to check for the restart key after the game is over doesn't work occasionally.
Beautiful documentation, great comments, nice docstrings, everything is there.
Implements the models well. Your code might have been a little more effective if you had also implemented a controller and a view. You have several functions that would be more effective if they were on a view object, such as the functions to draw the start screen and the restart prompt.
There are many variables that seem to be unused (like x_position, xx_position, and so on). It seems like you moved the x and y position information into a model and then didn't remove the initialization of these variables elsewhere.
Overall, good job. This is a large and ambitious project.
3 participants
This pull request creates 5 major revisions:
V1.0 (Base game)
V1.1 (Basic functionality and interaction)
V1.2 (Two player visuals)
V2.0 (Major bug fixes, sound support and multiplayer functionality)
V2.1 (Splash screen preface created, more bug fixes, fair play mechanisms (randomization of trajectory))