Open
Conversation
branchwelder
reviewed
Oct 5, 2016
branchwelder
left a comment
branchwelder
left a comment
There was a problem hiding this comment.
Very good job. I didn't really have any comments on formatting for you, besides that you might want to delete unused lines of code that you have commented out, unless you think you'll use them later.
tweetHarvest.py
Outdated
| for tweet in twitter.search(thread, geo=geocode(location)[:2],start=i,count=5, cached=False): | ||
| #print tweet.text | ||
| #print tweet.id | ||
There was a problem hiding this comment.
It's generally best practice to remove unused/commented out lines of code before submitting an assignment, or provide an explanation of why they are commented out.
| # decomposes the tweet into words, and weeds for items in the remove_list | ||
| dcomp_tweet = (tweet.text).split() | ||
| # removes RTs from the tweet | ||
| recombined_tweet = ' '.join([k for k in dcomp_tweet if k not in remove_list]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry im such a klutz i didn click on the final create LOL